Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receive notification messages from server and print received messages to console #2731

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

shi-su
Copy link
Contributor

@shi-su shi-su commented Aug 16, 2023

Issue #:

Description of changes:
Receive notification messages from server and print received messages to console.

Testing:
Added unit tests and smoke tested to verify messages are received and printed correctly.

Can these tested using a demo application? Please provide reproducible step-by-step instructions.
This requires server side to send messages. Currently, server-side message sending is not enabled, so not testable in demo application.

Checklist:

  1. Have you successfully run npm run build:release locally?
    Yes

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
    No

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
    No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@shi-su shi-su marked this pull request as ready for review August 16, 2023 21:04
@shi-su shi-su requested a review from a team as a code owner August 16, 2023 21:04
@shi-su shi-su merged commit 20f2e1a into main Aug 21, 2023
10 checks passed
@shi-su shi-su deleted the feedback branch August 21, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants